Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

laravel-ignition integration and CLI mode detection #88

Merged
merged 6 commits into from
Feb 12, 2022
Merged

laravel-ignition integration and CLI mode detection #88

merged 6 commits into from
Feb 12, 2022

Conversation

tarampampam
Copy link
Collaborator

@tarampampam tarampampam commented Feb 12, 2022 •
edited
Loading

Description

Added

Fixed

  • CLI running mode detection

Fixes tarampampam/laravel-roadrunner-in-docker#116

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I wrote unit tests for my code (if tests is required for my changes)
  • I have made changes in CHANGELOG.md file

@tarampampam tarampampam self-assigned this Feb 12, 2022
@tarampampam tarampampam mentioned this pull request Feb 12, 2022
Closed
@codecov
Copy link

codecov bot commented Feb 12, 2022 •
edited
Loading

Codecov Report

Merging #88 (eed6c39) into master (e260bef) will increase coverage by 0.05%.
The diff coverage is 81.25%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #88      +/-   ##
============================================
+ Coverage     78.32%   78.37%   +0.05%     
- Complexity      343      352       +9     
============================================
  Files            65       66       +1     
  Lines           858      874      +16     
============================================
+ Hits            672      685      +13     
- Misses          186      189       +3
Impacted Files Coverage Δ
src/Defaults.php 100.00% <ø> (ø)
src/Dumper/Dumper.php 87.50% <50.00%> (-3.41%) ⬇️
src/Listeners/ResetLaravelIgnitionListener.php 85.71% <85.71%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfd5bf6...eed6c39. Read the comment docs.

@tarampampam tarampampam marked this pull request as ready for review February 12, 2022 11:12
@tarampampam tarampampam merged commit 5d53c36 into master Feb 12, 2022
@tarampampam tarampampam deleted the ignition-and-cli branch February 12, 2022 11:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@tarampampam tarampampam

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error page not working on Laravel 9
1 participant
@tarampampam